Hi Juergen, > -----Original Message----- > From: Juergen Gross <jgr...@suse.com> > Subject: [PATCH-for-4.17] xen/sched: fix restore_vcpu_affinity() by removing > it > > When the system is coming up after having been suspended, > restore_vcpu_affinity() is called for each domain in order to adjust > the vcpu's affinity settings in case a cpu didn't come to live again. > > The way restore_vcpu_affinity() is doing that is wrong, because the > specific scheduler isn't being informed about a possible migration of > the vcpu to another cpu. Additionally the migration is often even > happening if all cpus are running again, as it is done without check > whether it is really needed. > > As cpupool management is already calling cpu_disable_scheduler() for > cpus not having come up again, and cpu_disable_scheduler() is taking > care of eventually needed vcpu migration in the proper way, there is > simply no need for restore_vcpu_affinity(). > > So just remove restore_vcpu_affinity() completely. > > Fixes: 8a5d50dd0b04 ("xen: sched: simplify ACPI S3 resume path.") > Reported-by: Marek Marczykowski-Górecki > <marma...@invisiblethingslab.com> > Signed-off-by: Juergen Gross <jgr...@suse.com>
Release-acked-by: Henry Wang <henry.w...@arm.com> Kind regards, Henry