On Wed, Nov 02, 2022 at 12:24:21PM +0000, Andrew Cooper wrote:
> On 02/11/2022 11:28, Anthony PERARD wrote:
> > Notes:
> > Maybe instead of this, we should just stamp this on the generated header
> > /* SPDX-License-Identifier: MIT */
> >
> > but we would be missing the "Copyright" informations. I guess we could
> > look for those line with Copyright and copy them.
> >
> > Or, we could replace the licence in the input header by a SPDX and have
> > the script parse that. (Probably still need to grab the Copyright lines)
>
> All public headers (except one :-( ) are MIT.
>
> We should SPDX the lot, not least because that removes all the
> guestimation from this script; we can require that the SPDX line is the
> first line, and sanity check it as we process it.
Yes, but I'm not sure I want to do the SPDX change when the tree is
supposed to be frozen.
> The headers also ought to say "automatically generated from $OTHER", and
> include no other information. That's now most autogen headers work.
>
> So the generated files ought to end up looking like:
>
> /* SPDX-License-Identifier: MIT */
> /* Automatically generated from $FILE */
So the headers already have:
/*
* public xen defines and struct for arm32
* generated by mkheader.py -- DO NOT EDIT
*/
So we just miss the source files used as input by mkheader.py. I can fix
that.
Thanks,
--
Anthony PERARD
