On 07.12.2022 00:27, Demi Marie Obenour wrote: > A previous patch tried to get Linux to use the ESRT under Xen if it is > in memory of type EfiRuntimeServicesData. However, this turns out to be > a bad idea. Ard Biesheuvel pointed out that EfiRuntimeServices* memory > winds up fragmenting both the EFI page tables and the direct map, and > that EfiACPIReclaimMemory is a much better choice for this purpose. > > Link: > https://lists.xenproject.org/archives/html/xen-devel/2022-09/msg01365.html > Fixes: dc7da0874ba4 ("EFI: preserve the System Resource Table for dom0") > Signed-off-by: Demi Marie Obenour <[email protected]> > --- > Should this be included in 4.17? It is a bug fix for a feature new to > 4.17, so I suspect yes, but it is ultimately up to Henry Wang.
First I was surprised this is numbered v2. But it indeed looks to be a plain re-submission, merely with Henry Cc-ed. You didn't address my comments; you didn't even incorporate the one adjustment where you suggested alternative wording and where I did signal my agreement. All this form of plain re-submission (without any kind of remark in that direction) did is that I spent (wasted) time checking what the earlier variant had, what was requested to be changed, and whether any of the changes were actually carried out. Jan
