On 23/01/2023 11:00 am, Jan Beulich wrote: > On 20.01.2023 16:31, Andrew Cooper wrote: >> On 20/01/2023 2:59 pm, Oleksii Kurochko wrote: >>> Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com> >> There's some stuff in here which is not RISCV-specific. We really want >> to dedup with the other architectures and move into common. > I have to admit that I'm not fully convinced in this case: What an arch > may or may not need in support of its assembly code may heavily vary. It > would need to be very generic thing which could be moved out. Then again > xen/asm.h feels like slightly odd a name with, as kind of already implied > above, assembly code being at times very specific to an architecture > (including e.g. formatting constraints or whether labels are to be > followed by colons).
Half of this header file is re-inventing generic concepts that we already spell differently in the Xen codebase. It is the difference between bolting something on the side, and integrating the code properly. ~Andrew
