On 23.01.2023 15:04, Oleksii wrote: > On Mon, 2023-01-23 at 14:52 +0100, Jan Beulich wrote: >> On 20.01.2023 15:59, Oleksii Kurochko wrote: >>> Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com> >> >> I was about to commit this, but ... >> >>> --- /dev/null >>> +++ b/xen/arch/riscv/include/asm/riscv_encoding.h >>> @@ -0,0 +1,945 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) */ >>> +/* >>> + * Copyright (c) 2019 Western Digital Corporation or its >>> affiliates. >>> + * >>> + * Authors: >>> + * Anup Patel <anup.pa...@wdc.com> >> >> ... this raises a patch authorship question: Are you missing her/his >> S-o-b: and/or From:? >> > It is not clear who should be in S-o-b and/or From. So let me explain > situation: > > Anup Patel <anup.pa...@wdc.com> is a person who introduced > riscv_encoding.h in OpenSBI. > > A person who introduced the header to Xen isn't clear as I see 3 people > who did it: > - Bobby Eshleman <bobbyeshle...@gmail.com> > - Alistair Francis <alistair.fran...@wdc.com> > - One more person whoose last name, unfortunately, I can't find > And in all cases I saw that an author is different.
Then maybe simply move the "Author:" part into ... >>> + * The source has been largely adapted from OpenSBI: >>> + * include/sbi/riscv_encodnig.h ... this sentence, e.g. by appending "originally authored by ..."? Jan
