On Mon, Mar 13, 2023 at 2:49 PM Daniel P. Smith
<[email protected]> wrote:
> On 3/13/23 13:50, Jason Andryuk wrote:
> > usage(argCnt, argv);
> >
> > + if (argCnt == 4) {
> > + pirq_label = argv[3];
> > + } else {
> > + pirq_label = argv[2];
> > + }
> > +
>
> style nit: space inside parens and curly brackets could be dropped or
> should be moved to their own lines.
This file doesn't follow Xen style. I think dropping the curly braces
is fine, but the lack of spaces 'if (argCnt == 4)' should stay for
consistency. Does that sound okay?
> > xch = xc_interface_open(0,0,0);
> > if ( !xch )
> > {
> > @@ -107,7 +114,7 @@ int main (int argCnt, char *argv[])
> > if (fscanf(f, "%" SCNu64, &start) != 1)
> > start = 0;
> > if (start) {
> > - ret = xc_flask_add_pirq(xch, start, argv[2]);
> > + ret = xc_flask_add_pirq(xch, start, pirq_label);
> > if (ret) {
> > fprintf(stderr, "xc_flask_add_pirq %"PRIu64" failed:
> > %d\n",
> > start, ret);
>
> Style nits aside, LGTM.
>
> Acked-by: Daniel P. Smith <[email protected]>
Thanks,
Jason
