On 13.03.2023 22:11, dpsmith.dev wrote: > On 3/13/23 15:14, Jason Andryuk wrote: >> On Mon, Mar 13, 2023 at 2:49 PM Daniel P. Smith >> <[email protected]> wrote: >>> On 3/13/23 13:50, Jason Andryuk wrote: >>>> usage(argCnt, argv); >>>> >>>> + if (argCnt == 4) { >>>> + pirq_label = argv[3]; >>>> + } else { >>>> + pirq_label = argv[2]; >>>> + } >>>> + >>> >>> style nit: space inside parens and curly brackets could be dropped or >>> should be moved to their own lines. >> >> This file doesn't follow Xen style. I think dropping the curly braces >> is fine, but the lack of spaces 'if (argCnt == 4)' should stay for >> consistency. Does that sound okay? >> > > Hmm, I thought there was interest in getting everything in tree consistent, > maybe I am mistaken. I am not hard pressed to enforce the style. Unless > someone else objects, I am good with your proposal.
The rule of thumb is that if a file is (largely) consistent in itself, then that style is preferred over introducing a mix. (I haven't checked this specific file, though.) The same may or may not apply to individual functions within a file; there it's more likely to be considered one way or the other on a case by case basis. Jan
