On 16.05.2023 16:53, Andrew Cooper wrote: > --- a/xen/arch/x86/include/asm/cpufeature.h > +++ b/xen/arch/x86/include/asm/cpufeature.h > @@ -7,6 +7,7 @@ > #define __ASM_I386_CPUFEATURE_H > > #include <xen/const.h> > +#include <xen/stdbool.h> > #include <asm/cpuid.h>
This isn't needed up here, and ... > @@ -17,7 +18,6 @@ > #define X86_FEATURE_ALWAYS X86_FEATURE_LM > > #ifndef __ASSEMBLY__ > -#include <xen/bitops.h> ... putting it here would (a) eliminate a header dependency for assembly sources including this file (perhaps indirectly) and (b) eliminate the risk of a build breakage if something was added to that header which isn't valid assembly. Preferably with the adjustment Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan
