On 17.05.2023 16:36, Jan Beulich wrote: > On 16.05.2023 16:53, Andrew Cooper wrote: >> MSR_ARCH_CAPS data is now included in featureset information. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > > Acked-by: Jan Beulich <jbeul...@suse.com>
Oops - this was really meant to be Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan > albeit, like in one of the patches in the earlier series, ... > >> --- a/xen/arch/x86/include/asm/cpufeature.h >> +++ b/xen/arch/x86/include/asm/cpufeature.h >> @@ -183,6 +183,9 @@ static inline bool boot_cpu_has(unsigned int feat) >> #define cpu_has_avx_vnni_int8 boot_cpu_has(X86_FEATURE_AVX_VNNI_INT8) >> #define cpu_has_avx_ne_convert boot_cpu_has(X86_FEATURE_AVX_NE_CONVERT) >> >> +/* MSR_ARCH_CAPS 10A */ >> +#define cpu_has_if_pschange_mc_no >> boot_cpu_has(X86_FEATURE_IF_PSCHANGE_MC_NO) > > ... I'm not convinced that having the (unadorned) MSR index here > is really helpful. In particular to people not knowing the indexes > by heart (possibly most except you) the number may actually look > odd / misplaced there. > > Jan >
