On 07.06.2023 14:45, Stewart Hildebrand wrote: > On 6/7/23 03:59, Jan Beulich wrote: >> On 07.06.2023 05:02, Stewart Hildebrand wrote: >>> --- a/xen/include/xen/iommu.h >>> +++ b/xen/include/xen/iommu.h >>> @@ -26,6 +26,9 @@ >>> #include <xen/spinlock.h> >>> #include <public/domctl.h> >>> #include <public/hvm/ioreq.h> >>> +#ifdef CONFIG_ACPI >>> +#include <asm/acpi.h> >>> +#endif >> >> This header is supposed to be usable without #ifdef, and then ... > > You suggested adding the #ifdef > > https://lists.xenproject.org/archives/html/xen-devel/2023-05/msg01409.html > > Please clarify
Hmm, indeed. Which is a sign that neither solution is really nice. I guess the one with #ifdef is slightly preferable because it'll avoid (as said in the earlier reply you refer to above) the need for every arch, even if ignorant of ACPI altogether, needing to have an asm/acpi.h. I guess we really need to deal with all of this better in / by having suitable common code. Jan
