Hi Julien, > On Sep 22, 2023, at 01:16, Julien Grall <[email protected]> wrote: > > Hi Henry, > > On 16/09/2023 05:06, Henry Wang wrote: >> Some addressed comments on enable_boot_cpu_mm() were reintroduced >> back during the code movement from arm64/head.S to arm64/mmu/head.S. >> We should drop the unreachable code, move the 'mov lr, x5' closer to >> 'b remove_identity_mapping' so it is clearer that it will return, >> and update the in-code comment accordingly. >> Fixes: 6734327d76be ("xen/arm64: Split and move MMU-specific head.S to >> mmu/head.S") >> Reported-by: Julien Grall <[email protected]> >> Signed-off-by: Henry Wang <[email protected]> > > Reviewed-by: Julien Grall <[email protected]>
Thanks very much! > > I plan to commit this patch in staging so it is part of 4.18. Please let me > know if there are any objection. Yes, please commit this patch, as it should have been part of the committed patch 6734327d76be (again I am sorry for the mess). Kind regards, Henry > > Cheers, > > -- > Julien Grall
