On 16.10.2023 20:06, Julien Grall wrote: > Instead, it would be best to find a way to help Eclair to detect this is > not an issue and also improve readability. Would the following help Eclair? > > diff --git a/xen/common/domain.c b/xen/common/domain.c > index 30c227967345..ab16124eabd6 100644 > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -671,6 +671,8 @@ struct domain *domain_create(domid_t domid, > > if ( !is_idle_domain(d) ) > { > + ASSERT(config); > + > watchdog_domain_init(d); > init_status |= INIT_watchdog;
Just to mention it: Even if right now it turned out to help, it wouldn't once release builds are also checked. Jan