On 23.10.2023 13:34, David Woodhouse wrote: > From: David Woodhouse <[email protected]> > > When switching to call the shim functions from the normal handlers, the > compat_grant_table_op() function was omitted, leaving it calling the > real grant table operations. This leaves a 32-bit shim guest failing to > set up its real grant table with the parent hypervisor. > > Fixes: e7db635f4428 ("x86/pv-shim: Don't modify the hypercall table") > Signed-off-by: David Woodhouse <[email protected]>
A patch with this same effect has been pending for a long time: https://lists.xen.org/archives/html/xen-devel/2023-03/msg00041.html (v2; I have a re-based v3 pending locally, awaiting whatever kind of feedback on v2). The question of whether it was necessary to split out the actual bug fix was raised yet earlier, in the context of v1 (albeit I'm not sure whether that was in email or on irc). Jan
