On 23/10/2023 12:34 pm, David Woodhouse wrote: > From: David Woodhouse <[email protected]> > > When switching to call the shim functions from the normal handlers, the > compat_grant_table_op() function was omitted, leaving it calling the > real grant table operations. This leaves a 32-bit shim guest failing to > set up its real grant table with the parent hypervisor. > > Fixes: e7db635f4428 ("x86/pv-shim: Don't modify the hypercall table") > Signed-off-by: David Woodhouse <[email protected]>
It's a bit more nuanced than that. It's only for shim built in non-exclusive mode, which is probably why XenServer's testing never found this. Reviewed-by: Andrew Cooper <[email protected]>
