On 01.11.23 19:36, Jason Andryuk wrote:
On Wed, Nov 1, 2023 at 10:27 AM Juergen Gross <jgr...@suse.com> wrote:Add "xenlogd", a new logging daemon meant to support infrastructure domains (e.g. xenstore-stubdom) to write log files in dom0.As I understand it, your new daemon is a generic 9pfs backend, which you use for logging. I think naming it something like xen9pfsd would more accurately describe its functionality.
Fine with me. I'll wait a little bit to see what others think.
For now only add the code needed for starting the daemon and registering it with Xenstore via a new "/tool/xenlog/state" node by writing the "running" state to it.To support driver domain use cases, I think you want to use a relative Xenstore path. While this daemon is independent from libxl, it might be easiest to use "libxl/xenlog/" ("libxl/xen9pfs/") to take advantage of driver domains having a read-write "libxl/" directory.
You have a point here. And as it is libxl controlling the start of the daemon, putting it under "libxl" is fine IMO.
Signed-off-by: Juergen Gross <jgr...@suse.com>The code looks good to me.
Thanks, Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
