On Thu, 2024-04-25 at 17:35 +0200, Jan Beulich wrote: > > /* --------------------- Please tidy above here ----------------- > > ---- */ > > > > #include <asm/bitops.h> > > > > +#ifndef arch_check_bitop_size > > +#define arch_check_bitop_size(addr) > > Can this really do nothing? Passing the address of an object smaller > than > bitop_uint_t will read past the object in the generic__*_bit() > functions. Agree, in generic case it would be better to add: #define arch_check_bitop_size(addr) (sizeof(*(addr)) < sizeof(bitop_uint_t))
Originally, it was defined as empty becuase majority of supported architectures by Xen don't do this check and I decided to use this definition as generic. Thanks. ~ Oleksii
