On 15/07/2024 2:39 pm, Anthony PERARD wrote:
> On Sat, Jul 13, 2024 at 07:10:05PM +0100, Andrew Cooper wrote:
>> Fedora 29 is long out of date. Move forward 5 years to Fedora 39.
>>
>> Inlcude all the usual improvements. Rework the container to be non-root, use
>> heredocs for legibility, and switch to the new naming scheme.
> "clang" as been removed, but it's not mention in the commit message.
Oops - I meant to mention that. We don't do any clang builds with this
container, so I though I'd keep it slimer until we change that.
> The
> other changes are kind of "the usual improvement" yes, as been done to
> other containers (libaio, nasm, ...).
>
> The patch is missing an update of the "containerize" script.
Ah - I found the hunk in a different patch. I'll fix.
>
>> diff --git a/automation/build/fedora/39-x86_64.dockerfile
>> b/automation/build/fedora/39-x86_64.dockerfile
>> new file mode 100644
>> index 000000000000..e2048a437581
>> --- /dev/null
>> +++ b/automation/build/fedora/39-x86_64.dockerfile
> ...
>> +
>> + dnf -y install "${DEPS[@]}"
> You might want to add --setopt=install_weak_deps=False to avoid
> installing "git" for example.
Well, git-core is installed explicitly, but point taken.
> When running the original command by hand, `dnf` want to install those weak
> deps:
> Installing weak dependencies:
> apr-util-bdb
> apr-util-openssl
> cryptsetup-libs
> diffutils
> git
> libbpf
> libxkbcommon
> mercurial
> perl-NDBM_File
> python3-fb-re2
> python3-pip
> qrencode-libs
> subversion
> systemd-networkd
> systemd-resolved
> And comparring the list of deps, these extra pkgs are installed because
> of weak deps:
> apr
> apr-util
> dbus
> dbus-broker
> dbus-common
> device-mapper
> device-mapper-libs
> git-core-doc
> kmod-libs
> libargon2
> libseccomp
> libserf
> perl-Error
> perl-File-Find
> perl-Git
> perl-TermReadKey
> perl-lib
> python3-zombie-imp
> re2
> subversion-libs
> systemd
> systemd-pam
> utf8proc
> xkeyboard-config
>
> So, probably only "perl-File-Find" (can be written "perl(File::Find)" I
> think as well) might be needed, but only for docs/ I think, from the
> previous email.
>
> It seems I go from 1.26GB to 1.18GB without those weak deps.
Thanks. I'll rework.
I have a specific plan for testing docs and it's going to be a dedicated
container and job, as well as things being a bit more -Werror-like.
~Andrew
