On 15/07/2024 5:53 pm, Anthony PERARD wrote:
> On Mon, Jul 15, 2024 at 04:16:40PM +0100, Andrew Cooper wrote:
>> xeninfo.pl was introduced in commit 1b0a8bb57e3e ("Added xeninfo.pl, a script
>> for collecting statistics from Xen hosts using the Xen-API") and has been
>> touched exactly twice since to remove hardcoded IP addresses and paths.
> Xen-API, is that xapi?Yes. xapi is a contraction of Xen-API, but even the docs intermix the two names. https://xapi-project.github.io/xen-api/ > >> The configuration files in vnc/* date from when we had a vendered version of >> Qemu living in the tree. > I guess QEMU at that time didn't have VNC support? Because looks like > the vnc config was supposed to be put in a guest, and `xm` had support > for it. Thinking about it, this may have been for PV guests instead. We used to have a mode in XenServer to inject vnc configuration into a PV guest in order to get a GUI installer rather than the TUI one. Either way, xl doesn't have --vnc, although it does have -V which seems to have subsumed this functionality. > >> These have never (AFAICT) been wired into the `make install` rule. >> >> Signed-off-by: Andrew Cooper <[email protected]> > Anyway, patch looks good: > Reviewed-by: Anthony PERARD <[email protected]> Thanks, ~Andrew
