On 2024-10-06 17:49, Daniel P. Smith wrote:
From: Christopher Clark <christopher.w.cl...@gmail.com>

An initial step towards a non-multiboot internal representation of boot
modules for common code, starting with x86 setup and converting the fields
that are accessed for the startup calculations.

Introduce a new header, <asm/bootinfo.h>, and populate it with a new boot_info
structure initially containing a count of the number of boot modules.

No functional change intended.

Signed-off-by: Christopher Clark <christopher.w.cl...@gmail.com>
Signed-off-by: Daniel P. Smith <dpsm...@apertussolutions.com>
---
  xen/arch/x86/include/asm/bootinfo.h | 29 +++++++++++++
  xen/arch/x86/include/asm/setup.h    |  2 +
  xen/arch/x86/setup.c                | 64 ++++++++++++++++++-----------
  3 files changed, 71 insertions(+), 24 deletions(-)
  create mode 100644 xen/arch/x86/include/asm/bootinfo.h

diff --git a/xen/arch/x86/include/asm/bootinfo.h 
b/xen/arch/x86/include/asm/bootinfo.h
new file mode 100644
index 000000000000..a649500ee3a2
--- /dev/null
+++ b/xen/arch/x86/include/asm/bootinfo.h
@@ -0,0 +1,29 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * Copyright (c) 2024 Christopher Clark <christopher.w.cl...@gmail.com>
+ * Copyright (c) 2024 Apertus Solutions, LLC
+ * Author: Daniel P. Smith <dpsm...@apertussolutions.com>
+ */
+
+#ifndef __XEN_X86_BOOTINFO_H__
+#define __XEN_X86_BOOTINFO_H__

I haven't been following closely, but I think if we follow Frediano's naming scheme, it would be:
ASM__X86__BOOTINFO_H

With that (or whatever it should be),
Reviewed-by: Jason Andryuk <jason.andr...@amd.com>

+
+/*
+ * Xen internal representation of information provided by the
+ * bootloader/environment, or derived from the information.
+ */

I guess fine for now. Should probably be expanded when it starts containing Hyperlaunch domain configs.

+struct boot_info {
+    unsigned int nr_modules;
+};
+
+#endif /* __XEN_X86_BOOTINFO_H__ */

Regards,
Jason

Reply via email to