Re: [PATCH v5 02/44] x86/boot: move boot loader name to boot info

[Daniel P. Smith]

On 10/9/24 11:07, Jan Beulich wrote:

On 06.10.2024 23:49, Daniel P. Smith wrote:

--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -285,6 +285,9 @@ static struct boot_info __init 
*multiboot_fill_boot_info(unsigned long mbi_p)

bi->nr_modules = (mbi->flags & MBI_MODULES) ? mbi->mods_count : 0; + bi->loader = (mbi->flags & MBI_LOADERNAME) ?

+                            __va(mbi->boot_loader_name) : "unknown";

Either (noting that generally we exempt ?: from the operator-on-earlier-line
rule)

     bi->loader = (mbi->flags & MBI_LOADERNAME) ? __va(mbi->boot_loader_name)
                                                : "unknown";

or

     bi->loader = (mbi->flags & MBI_LOADERNAME)
                  ? __va(mbi->boot_loader_name) : "unknown";

or

     bi->loader = (mbi->flags & MBI_LOADERNAME)
         ? __va(mbi->boot_loader_name) : "unknown";

(in the order of my personal preference).

I would prefer the first as well. Will adjust.

v/r,
dps