On 09.10.2024 16:23, Daniel P. Smith wrote: > On 10/7/24 15:34, Jason Andryuk wrote: >> On 2024-10-06 17:49, Daniel P. Smith wrote: >>> --- a/xen/arch/x86/setup.c >>> +++ b/xen/arch/x86/setup.c >>> @@ -1341,15 +1341,15 @@ void asmlinkage __init noreturn >>> __start_xen(unsigned long mbi_p) >>> set_kexec_crash_area_size((u64)nr_pages << PAGE_SHIFT); >>> kexec_reserve_area(); >>> - initial_images = mod; >>> + initial_images = bi->mods[0].mod; >> >> Isn't this wrong? >> mod is the array of module_t * of *all* modules, but bi->mods[0].mod is >> a single module_t *? > > No it is not wrong: > bi->mods[0].mod == __va(mbi->mods_addr)[0]
Yet as it's seemingly wrong, a comment appears to be necessary. Jan
