Re: [PATCH v5 09/44] x86/boot: introduce boot module types

[Jan Beulich]

On 06.10.2024 23:49, Daniel P. Smith wrote:
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -311,6 +311,10 @@ static struct boot_info __init 
> *multiboot_fill_boot_info(unsigned long mbi_p)
>      for ( i = 0; i <= bi->nr_modules; i++ )
>          bi->mods[i].mod = &mods[i];

This loop, on its last iteration, has done ...

> +    /* map the last mb module for xen entry */
> +    bi->mods[bi->nr_modules].type = BOOTMOD_XEN;
> +    bi->mods[bi->nr_modules].mod = &mods[bi->nr_modules];

... this assignment already, hasn't it?

Jan