On 10/8/24 15:36, Jason Andryuk wrote:
On 2024-10-06 17:49, Daniel P. Smith wrote:
Add a domid field to struct boot_domain to hold the assigned domain id for the domain. During initialization, ensure all instances of struct boot_domain have the invalid domid to ensure that the domid must be set either by convention or
configuration.

Signed-off-by: Daniel P. Smith <dpsm...@apertussolutions.com>
---
  xen/arch/x86/include/asm/bootdomain.h |  2 ++
  xen/arch/x86/setup.c                  | 12 +++++++-----
  2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/xen/arch/x86/include/asm/bootdomain.h b/xen/arch/x86/include/asm/bootdomain.h
index 4285223ac5ab..d6264d554dba 100644
--- a/xen/arch/x86/include/asm/bootdomain.h
+++ b/xen/arch/x86/include/asm/bootdomain.h
@@ -11,6 +11,8 @@
  struct boot_module;
  struct boot_domain {
+    domid_t domid;
+
      struct boot_module *kernel;
      struct boot_module *ramdisk;
  };

Oh, you should probably move domid after the pointers to avoid a hole.

It's not a packed structure and at this point, we are not looking to make it an ABI. If the maintainers think there is a real concern here, then I can add a reserved field to fill the hole.

v/r,
dps

Reply via email to