On 18.11.2024 09:49, ngoc-tu.d...@vates.tech wrote: > --- a/xen/arch/x86/include/asm/msr-index.h > +++ b/xen/arch/x86/include/asm/msr-index.h > @@ -304,6 +304,17 @@
Please note this comment around line 250: /* * Legacy MSR constants in need of cleanup. No new MSRs below this comment. */ You want to ... > #define MSR_IA32_LASTINTFROMIP 0x000001dd > #define MSR_IA32_LASTINTTOIP 0x000001de > > +/* Architectural LBR state MSRs */ > +#define MSR_IA32_LASTBRANCH_CTL 0x000014ce > +#define LASTBRANCH_CTL_LBREN (1<<0) /* Enable LBR recording > */ > +#define LASTBRANCH_CTL_VALID _AC(0x7f000f, ULL) > +#define MSR_IA32_LASTBRANCH_DEPTH 0x000014cf > +#define MSR_IA32_LER_INFO 0x000001e0 > +#define MSR_IA32_LASTBRANCH_0_INFO 0x00001200 > +#define MSR_IA32_LASTBRANCH_0_FROM_IP 0x00001500 > +#define MSR_IA32_LASTBRANCH_0_TO_IP 0x00001600 > +#define MAX_MSR_ARCH_LASTBRANCH_FROM_TO 64 ... move your addition up, omit the IA32 infixes, format according to how other entries there are formatted, and sort numerically (implying these can't all stay together). Jan
