On 12/2/24 06:37, Jan Beulich wrote:
On 23.11.2024 19:20, Daniel P. Smith wrote:
Add the ability to detect both a formal hyperlaunch device tree or a dom0less
device tree. If the hyperlaunch device tree is found, then count the number of
domain entries, reporting if more than one is found.
"reporting" reads like informational logging, when comment and printk() in
walk_hyperlaunch_fdt() indicate this is actually an error (for now).
That is not a shared assumptive reading. It is equally correct to say I
will report info and I will report an error. With that said, I can make
it explicit.
--- a/xen/arch/x86/domain_builder/fdt.c
+++ b/xen/arch/x86/domain_builder/fdt.c
@@ -14,14 +14,76 @@
#include "fdt.h"
+static int __init find_hyperlaunch_node(void *fdt)
+{
+ int hv_node = fdt_path_offset(fdt, "/chosen/hypervisor");
+ if ( hv_node >= 0 )
Nit: Blank line between declaration(s) and statement(s) please (also
elsewhere).
ack.
--- a/xen/arch/x86/domain_builder/fdt.h
+++ b/xen/arch/x86/domain_builder/fdt.h
@@ -11,11 +11,16 @@
#ifdef CONFIG_DOMAIN_BUILDER
int has_hyperlaunch_fdt(struct boot_info *bi);
+int walk_hyperlaunch_fdt(struct boot_info *bi);
#else
static inline int __init has_hyperlaunch_fdt(struct boot_info *bi)
{
return -EINVAL;
}
+static int __init walk_hyperlaunch_fdt(struct boot_info *bi)
inline?
Should have been.
v/r,
dps
