> -----Original Message----- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 10 July 2018 15:01 > To: Paul Durrant <paul.durr...@citrix.com>; xen-devel@lists.xenproject.org > Cc: Jan Beulich <jbeul...@suse.com>; Andrew Cooper > <andrew.coop...@citrix.com>; George Dunlap > <george.dun...@citrix.com>; Ian Jackson <ian.jack...@citrix.com>; Konrad > Rzeszutek Wilk <konrad.w...@oracle.com>; Stefano Stabellini > <sstabell...@kernel.org>; Julien Grall <julien.gr...@arm.com>; Tim (Xen.org) > <t...@xen.org>; Wei Liu <wei.l...@citrix.com>; Jun Nakajima > <jun.nakaj...@intel.com>; Kevin Tian <kevin.t...@intel.com> > Subject: Re: [PATCH v2 03/13] iommu: make use of type-safe BFN and MFN > in exported functions > > On 07/07/2018 12:05 PM, Paul Durrant wrote: > > This patch modifies the declaration of the entry points to the IOMMU > > sub-system to use bfn_t and mfn_t in place of unsigned long. A > subsequent > > patch will similarly modify the methods in the iommu_ops structure. > > > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > > --- > > Cc: Jan Beulich <jbeul...@suse.com> > > Cc: Andrew Cooper <andrew.coop...@citrix.com> > > Cc: George Dunlap <george.dun...@eu.citrix.com> > > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > > Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > > Cc: Stefano Stabellini <sstabell...@kernel.org> > > Cc: Julien Grall <julien.gr...@arm.com> > > Cc: Tim Deegan <t...@xen.org> > > Cc: Wei Liu <wei.l...@citrix.com> > > Cc: Jun Nakajima <jun.nakaj...@intel.com> > > Cc: Kevin Tian <kevin.t...@intel.com> > > Cc: George Dunlap <george.dun...@eu.citrix.com> > > > > v2: > > - Addressed comments from Jan. > > - Use intermediate 'frame' variable to avoid directly encapsulating > > mfn or gfn values as bfns. > > Explain this one to me? At the moment I don't see any value from having > the extra variable in the middle.
This was something that Jan wanted. Paul > > Everything else looks good. > > -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel