On 13/05/2025 10:45, Luca Fancellu wrote:
> From: Penny Zheng <penny.zh...@arm.com>
>
> Introduce pr_t typedef which is a structure having the prbar
> and prlar members, each being structured as the registers of
> the AArch64 Armv8-R architecture.
>
> Signed-off-by: Penny Zheng <penny.zh...@arm.com>
> Signed-off-by: Wei Chen <wei.c...@arm.com>
> Signed-off-by: Luca Fancellu <luca.fance...@arm.com>
> ---
> Changes in v5:
> - Given some comments on the page.h flags, I had to rework some
> fields here to better match the flags usage and avoid duplication
> Changes in v4:
> - Fixed typos, changed name for reserved bitfields, add emacs bits
> to arm64/mpu.h.
> Now base and limit are 42 bits as we consider FEAT_LPA disabled,
> since we support max 1TB of memory.
> Moved data structure in commit that uses it
> ---
> xen/arch/arm/include/asm/arm64/mpu.h | 52 ++++++++++++++++++++++++++++
> xen/arch/arm/include/asm/mpu.h | 4 +++
> 2 files changed, 56 insertions(+)
> create mode 100644 xen/arch/arm/include/asm/arm64/mpu.h
>
> diff --git a/xen/arch/arm/include/asm/arm64/mpu.h
> b/xen/arch/arm/include/asm/arm64/mpu.h
> new file mode 100644
> index 000000000000..d3c055a2e53b
> --- /dev/null
> +++ b/xen/arch/arm/include/asm/arm64/mpu.h
> @@ -0,0 +1,52 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +
> +#ifndef __ARM_ARM64_MPU_H__
> +#define __ARM_ARM64_MPU_H__
Given that Andrew's CODING_STYLE update \wrt headers went it, I think we should
adhere to it in new files. Other than that:
Reviewed-by: Michal Orzel <michal.or...@amd.com>
~Michal
