On Fri May 30, 2025 at 11:04 PM CEST, Jason Andryuk wrote: > On 2025-05-30 08:02, Alejandro Vallejo wrote: >> Not a functional change. >> >> Signed-off-by: Alejandro Vallejo <agarc...@amd.com> > > Some sort of reason would be good in the commit message. > > "struct pci_dev is used in function prototypes within the header. This > is in preparation for including (transitively) in device tree"?
> > ... I'm guessing that is why. Stating it would be better. Yes, but I'm not sure the second part of that explanation is relevant. Unless specifically noted in the header, they are meant to stand by themselves when possible and not require preinclusion of something else (in this case, xen/pci.h). This patch would still be relevant (imo) even if I wasn't using the header for anything. > > With a suitable reason: > > Reviewed-by: Jason Andryuk <jason.andr...@amd.com> Thanks, Does this sound reasonable? struct pci_dev is used in function prototypes within the header, so it must be forward declared for asm/pci.h not to depend on xen/pci.h being included first. > > Regards, > Jason Cheers, Alejandro
