On 10.09.2025 09:38, Penny Zheng wrote: > Function domain_soft_reset() is responsible for domain soft reset domctl-op, > and shall be wrapped with CONFIG_MGMT_HYPERCALLS > Tracking its calling chain, and the following functions shall also be wrapped > with CONFIG_MGMT_HYPERCALLS: > - grant_table_warn_active_grants() > - argo_soft_reset() > - arch_domain_soft_reset() > Wrap XEN_DOMCTL_soft_reset-case transiently with CONFIG_MGMT_HYPERCALLS, and > it will be removed when introducing CONFIG_MGMT_HYPERCALLS on the > common/domctl.c in the last. > > Signed-off-by: Penny Zheng <penny.zh...@amd.com> > --- > v1 -> v2: > - remove unnessary wrapping in stub.c > - adapt to changes of "unify DOMCTL to MGMT_HYPERCALLS" > - wrap XEN_DOMCTL_soft_reset-case transiently > --- > xen/arch/arm/domain.c | 2 ++ > xen/arch/x86/domain.c | 2 ++
What about PPC and RISC-V? They have the function in stubs.c, but not adding the #ifdef there increases the chance that when the stubs are replaced by real functions, the intended #ifdef might then be forgotten to add. Jan