On 12.09.2025 09:18, Penny, Zheng wrote: > [Public] > >> -----Original Message----- >> From: Jan Beulich <jbeul...@suse.com> >> Sent: Wednesday, September 10, 2025 11:14 PM >> To: Penny, Zheng <penny.zh...@amd.com> >> Cc: Huang, Ray <ray.hu...@amd.com>; Stefano Stabellini >> <sstabell...@kernel.org>; Julien Grall <jul...@xen.org>; Bertrand Marquis >> <bertrand.marq...@arm.com>; Orzel, Michal <michal.or...@amd.com>; >> Volodymyr Babchuk <volodymyr_babc...@epam.com>; Andrew Cooper >> <andrew.coop...@citrix.com>; Anthony PERARD <anthony.per...@vates.tech>; >> Roger Pau Monné <roger....@citrix.com>; Christopher Clark >> <christopher.w.cl...@gmail.com>; Daniel P. Smith >> <dpsm...@apertussolutions.com>; xen-devel@lists.xenproject.org >> Subject: Re: [PATCH v2 08/26] xen/domctl: wrap domain_soft_reset() with >> CONFIG_MGMT_HYPERCALLS >> >> On 10.09.2025 09:38, Penny Zheng wrote: >>> Function domain_soft_reset() is responsible for domain soft reset >>> domctl-op, and shall be wrapped with CONFIG_MGMT_HYPERCALLS Tracking >>> its calling chain, and the following functions shall also be wrapped >>> with CONFIG_MGMT_HYPERCALLS: >>> - grant_table_warn_active_grants() >>> - argo_soft_reset() >>> - arch_domain_soft_reset() >>> Wrap XEN_DOMCTL_soft_reset-case transiently with >>> CONFIG_MGMT_HYPERCALLS, and it will be removed when introducing >>> CONFIG_MGMT_HYPERCALLS on the common/domctl.c in the last. >>> >>> Signed-off-by: Penny Zheng <penny.zh...@amd.com> >>> --- >>> v1 -> v2: >>> - remove unnessary wrapping in stub.c >>> - adapt to changes of "unify DOMCTL to MGMT_HYPERCALLS" >>> - wrap XEN_DOMCTL_soft_reset-case transiently >>> --- >>> xen/arch/arm/domain.c | 2 ++ >>> xen/arch/x86/domain.c | 2 ++ >> >> What about PPC and RISC-V? They have the function in stubs.c, but not adding >> the >> #ifdef there increases the chance that when the stubs are replaced by real >> functions, the intended #ifdef might then be forgotten to add. > > As we are addressing concerns on the v1 about editing stubs.c files [1], I > removed them all in this patch serie. If they are considered necessary now, > I'll add them back in next version > [1] https://lists.xenproject.org/archives/html/xen-devel/2025-08/msg00135.html
Hmm, looks like I changed my perspective, previously not having taken into account the aspect mentioned above. I'm sorry for the back and forth. And yes, it is on the edge, seeing also what Stefano said. I guess I should say "okay either way, with (now) a slight preference to also adding the #ifdef-s there". Jan
