On 24.11.25 11:41, Jan Beulich wrote:
On 21.11.2025 14:23, Juergen Gross wrote:
--- a/Config.mk
+++ b/Config.mk
@@ -159,6 +159,19 @@ define move-if-changed
        if ! cmp -s $(1) $(2); then mv -f $(1) $(2); else rm -f $(1); fi
  endef
+PATH_FILES := Paths
+INC_FILES = $(foreach f, $(PATH_FILES), $(XEN_ROOT)/config/$(f).mk)
+
+include $(INC_FILES)
+
+BUILD_MAKE_VARS = $(foreach f, $(PATH_FILES), $(shell awk '$$2 == ":=" { print 
$$1; }' $(XEN_ROOT)/config/$(f).mk.in))

Feels like my prior comments weren't really addressed. I continue to think that
none of the above is part of what the subject says.

I really don't understand your concern here.

For replacing the @markers@ make needs to know what should be replaced.
So it needs to scan the files containing the markers and gather them.
This is what is done above.

In the final macro below the replacements are done then. How would you
handle that?


+# Replace @xxx@ markers in $(1).in with $(xxx) variable contents, write to $(1)
+define apply-build-vars
+ $(1): $(1).in $$(INC_FILES)

I further understood your reply to my v2 comment the way that you would drop the
slightly odd leading blank from here.

Oh, with no further response I didn't see a reason to act immediately.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to