> -----Original Message----- > From: Roger Pau Monne [mailto:roger....@citrix.com] > Sent: 23 January 2019 18:08 > To: xen-devel@lists.xenproject.org > Cc: Roger Pau Monne <roger....@citrix.com>; Jan Beulich > <jbeul...@suse.com>; Paul Durrant <paul.durr...@citrix.com> > Subject: [PATCH for-4.12] iommu: fix order of arguments in iommu_map call > at iommu_hwdom_init > > The order of the page_order and the flags parameters are inverted in > the call to iommu_map made in iommu_hwdom_init. > > Fixes: e8afe1124cc1 ("iommu: elide flushing for higher order map/unmap > operations") > Signed-off-by: Roger Pau Monné <roger....@citrix.com>
Good grief. I was clearly having a bad day. Reviewed-by: Paul Durrant <paul.durr...@citrix.com> > --- > Cc: Jan Beulich <jbeul...@suse.com> > Cc: Paul Durrant <paul.durr...@citrix.com> > --- > xen/drivers/passthrough/iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/drivers/passthrough/iommu.c > b/xen/drivers/passthrough/iommu.c > index 98e6fc35e2..acd17ac2dc 100644 > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -226,7 +226,7 @@ void __hwdom_init iommu_hwdom_init(struct domain *d) > == PGT_writable_page) ) > mapping |= IOMMUF_writable; > > - ret = iommu_map(d, _dfn(dfn), _mfn(mfn), mapping, 0, > + ret = iommu_map(d, _dfn(dfn), _mfn(mfn), 0, mapping, > &flush_flags); > > if ( !rc ) > -- > 2.20.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
