>>> On 24.01.19 at 10:43, <paul.durr...@citrix.com> wrote: >> -----Original Message----- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 24 January 2019 09:41 >> To: Roger Pau Monne <roger....@citrix.com> >> Cc: Paul Durrant <paul.durr...@citrix.com>; xen-devel <xen- >> de...@lists.xenproject.org> >> Subject: Re: [PATCH for-4.12] iommu: fix order of arguments in iommu_map >> call at iommu_hwdom_init >> >> >>> On 23.01.19 at 19:08, <roger....@citrix.com> wrote: >> > The order of the page_order and the flags parameters are inverted in >> > the call to iommu_map made in iommu_hwdom_init. >> > >> > Fixes: e8afe1124cc1 ("iommu: elide flushing for higher order map/unmap >> operations") >> > Signed-off-by: Roger Pau Monné <roger....@citrix.com> >> >> Reviewed-by: Jan Beulich <jbeul...@suse.com> >> >> If you don't mind I'd convert to PAGE_ORDER_4K while committing. > > No, I don't think that's correct is it? This code is common, not x86 > specific and so 4K may not be the base order.
Oh, indeed, right you are. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
