Am Thu, 16 May 2019 12:24:50 +0100 schrieb Wei Liu <wei.l...@citrix.com>:
> The problem with this approach is that it doesn't help existing libxl > users. They will need to be fixed by calling this new API. If the API needs to be changed, a LIBXL_HAVE_ came with the change. I'm not sure how to fix this without changing some API. libxl__domain_build_info_setdefault would need a d_config to make a usable decision. The callers do not have a d_config. And what their calles have is an incomplete d_config because libxl lacks a public API to properly populate missing defaults in d_config. To me it looks like something like libxl_domain_config_finish(libxl_domain_config*) is missing now. Maybe I am just misunderstanding what you trying to say, but to me it looks like freemem() would need to call an updated libxl public API anyway. Surely not freemem itself, but xl:create_domain as a whole. Olaf
pgp7HSy_8CAos.pgp
Description: Digitale Signatur von OpenPGP
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
