Am Thu, 16 May 2019 12:50:43 +0100 schrieb Wei Liu <wei.l...@citrix.com>:
> Adding new APIs and defining LIBXL_HAVE won't get you out of this hole. From what I see, src/libxl/libxl_conf.c:libxlBuildDomainConfig would need to call libxl_domain_config_finish(libxl_domain_config*) at the end of that function, wrapped in a #ifdef. But your are right, old libvirt and new libxl need a solution without introducing a new API. There are quite a few checks for device_model_version, they would be all wrong if the assert is removed, or changed back to QEMU_XEN. Perhaps we can continue to live with that error. device_model_version could become a local variable. If it is not set, assume the caller just wants the memory size and enforce QEMU_XEN again within that function. Olaf
pgp9ZUL9sBykM.pgp
Description: Digitale Signatur von OpenPGP
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
