On 26.07.2019 15:33, Roger Pau Monne wrote: > Don't force the usage of the hardcoded compiler values if those are > already set on the environment. This allows the Xen build system to > correctly pick CC/CXX values present on the environment, and fixes the > usage of those by the Gitlab CI test system. > > Note that without this fix the Xen build system will completely ignore > any CC or CXX values set on the environment, and the only way to pass > a different CC or CXX is to overwrite it on the make command line.
Now the question is: Do we possibly want it to be that way? I've always been of the opinion that inheriting something that happens to be (left?) set in the environment is not a good idea. Hence I've been welcoming all changes that removed dependencies on settings possibly coming from the environment. (Exceptions of course are XEN_* environment variables we specifically evaluate.) As a result I'm inclined to nak this patch, but I'm open to arguments. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
