On 31/07/2019 09:47, Roger Pau Monné wrote: > On Tue, Jul 30, 2019 at 06:07:54PM +0100, Andrew Cooper wrote: >> c/s 201f852eaf added start_info.h and kconfig.h to reloc.c, but only updated >> start_info.h in RELOC_DEPS. >> >> This causes reloc.c to not be regenerated when Kconfig changes. It is most >> noticeable when enabling CONFIG_PVH and finding the resulting binary crash >> early with: >> >> (d9) (XEN) >> (d9) (XEN) **************************************** >> (d9) (XEN) Panic on CPU 0: >> (d9) (XEN) Magic value is wrong: c2c2c2c2 >> (d9) (XEN) **************************************** >> (d9) (XEN) >> (d9) (XEN) Reboot in five seconds... >> (XEN) d9v0 Triple fault - invoking HVM shutdown action 1 >> >> Reported-by: Paul Durrant <paul.durr...@citrix.com> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Roger Pau Monné <roge.r...@citrix.com>
:) I can use that tag if you'd like. > > Note sure if it's worth spelling out that multiboot.h dependency was > also missing. The delta to multiboot.h was a consequence of reformatting. It was present before. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
