On 31/07/2019 11:38, Wei Liu wrote: > On Tue, 30 Jul 2019 at 18:08, Andrew Cooper <andrew.coop...@citrix.com> wrote: >> c/s 201f852eaf added start_info.h and kconfig.h to reloc.c, but only updated >> start_info.h in RELOC_DEPS. >> >> This causes reloc.c to not be regenerated when Kconfig changes. It is most >> noticeable when enabling CONFIG_PVH and finding the resulting binary crash >> early with: >> >> (d9) (XEN) >> (d9) (XEN) **************************************** >> (d9) (XEN) Panic on CPU 0: >> (d9) (XEN) Magic value is wrong: c2c2c2c2 >> (d9) (XEN) **************************************** >> (d9) (XEN) >> (d9) (XEN) Reboot in five seconds... >> (XEN) d9v0 Triple fault - invoking HVM shutdown action 1 >> > Nice. I saw this before but never got around fixing it. Thanks for > tracking it down. :-)
It has been bugging me for ages, and yet still took Paul stumbling over it to wonder "how hard would this to be to figure out properly?". The answer is 10s to identify the likely cause, and far longer than that to debug the dependency tracking part. This bit of the build system is nasty. David Woodhouse had an idea of how to drop it all, so with any luck, it isn't going to survive long. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
