On 10/09/2019 16:25, Roger Pau Monne wrote:
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index 3ff67792a7..e8f5ebe929 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -401,6 +401,12 @@
>   */
>  #define LIBXL_HAVE_PHYSINFO_CAP_HAP 1
>  
> +/*
> + * LIBXL_HAVE_PHYSINFO_CAP_HAP indicates that libxl_physinfo has a cap_shadow
> + * field that indicates whether software implemented paging is supported.
> + */
> +#define LIBXL_HAVE_PHYSINFO_CAP_SHADOW 1
> +

Is it really worth doing this, and not extending the previous define? 
Very little point having two going into the tree at the same time.

> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
> index a5e77c943a..9f56e1df1a 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -108,6 +108,7 @@ type physinfo_cap_flag =
>       | CAP_PV
>       | CAP_DirectIO
>       | CAP_hap
> +     | CAP_shadow

Similarly as with HAP, this should at least be Shadow to match DirectIO.

Can be fixed on commit.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to