> -----Original Message----- > From: Roger Pau Monné <[email protected]> > Sent: 30 July 2020 11:08 > To: Jan Beulich <[email protected]> > Cc: Andrew Cooper <[email protected]>; > [email protected]; George Dunlap > <[email protected]>; Ian Jackson <[email protected]>; Julien > Grall <[email protected]>; > Stefano Stabellini <[email protected]>; Wei Liu <[email protected]>; Paul > Durrant <[email protected]>; Kevin > Tian <[email protected]>; Julien Grall <[email protected]> > Subject: Re: [PATCH v3] print: introduce a format specifier for pci_sbdf_t > > On Wed, Jul 29, 2020 at 09:28:53PM +0200, Jan Beulich wrote: > > On 27.07.2020 12:31, Roger Pau Monne wrote: > > > The new format specifier is '%pp', and prints a pci_sbdf_t using the > > > seg:bus:dev.func format. Replace all SBDFs printed using > > > '%04x:%02x:%02x.%u' to use the new format specifier. > > > > > > No functional change intended. > > > > > > Signed-off-by: Roger Pau Monné <[email protected]> > > > Reviewed-by: Kevin Tian <[email protected]> > > > Acked-by: Julien Grall <[email protected]> > > > For just the pieces where Jan is the only maintainer: > > > Acked-by: Jan Beulich <[email protected]> > [...] > > In all reality, Roger, it looks to me as if you should have dropped > > my ack, as there seems to be nothing left at this point that I'm > > the only maintainer of. > > Yes, just realized that now, I'm sorry. Your Ack happened before Paul > became a maintainer of vendor-independent IOMMU code and I completely > forgot about it. > > I think the overall result of having a modifier for printing SBDFs is > a win for everyone. TBH I just revived the patch because I think it > will be helpful to the Arm folks doing the PCI work, if not I wouldn't > have sent it again.
FWIW I am in favour of change. Paul > > Roger.
