On 30.07.2020 12:08, Roger Pau Monné wrote: > On Wed, Jul 29, 2020 at 09:28:53PM +0200, Jan Beulich wrote: >> On 27.07.2020 12:31, Roger Pau Monne wrote: >>> The new format specifier is '%pp', and prints a pci_sbdf_t using the >>> seg:bus:dev.func format. Replace all SBDFs printed using >>> '%04x:%02x:%02x.%u' to use the new format specifier. >>> >>> No functional change intended. >>> >>> Signed-off-by: Roger Pau Monné <[email protected]> >>> Reviewed-by: Kevin Tian <[email protected]> >>> Acked-by: Julien Grall <[email protected]> >>> For just the pieces where Jan is the only maintainer: >>> Acked-by: Jan Beulich <[email protected]> > [...] >> In all reality, Roger, it looks to me as if you should have dropped >> my ack, as there seems to be nothing left at this point that I'm >> the only maintainer of. > > Yes, just realized that now, I'm sorry. Your Ack happened before Paul > became a maintainer of vendor-independent IOMMU code and I completely > forgot about it. > > I think the overall result of having a modifier for printing SBDFs is > a win for everyone.
No-one disagrees here, I think. It's the "how", not the "what" that was controversial. > TBH I just revived the patch because I think it > will be helpful to the Arm folks doing the PCI work, if not I wouldn't > have sent it again. Yes, I understood this to be the case. Jan
