On 15.09.2020 12:49, Roger Pau Monné wrote: > On Mon, Sep 14, 2020 at 02:39:08PM +0200, Jan Beulich wrote: >> Just like HVM, defaulting SHADOW_PAGING and TBOOT to Yes in shim- >> exclusive mode makes no sense, as the respective code is dead there. >> >> Also adjust the shim default config file: It needs to specifiy values >> only for settings where a non-default value is wanted. >> >> Signed-off-by: Jan Beulich <[email protected]> > > Reviewed-by: Roger Pau Monné <[email protected]>
Thanks. >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -116,9 +116,9 @@ config XEN_SHSTK >> compatiblity can be provided via the PV Shim mechanism. >> >> config SHADOW_PAGING >> - bool "Shadow Paging" >> - default y >> - ---help--- >> + bool "Shadow Paging" >> + default y if !PV_SHIM_EXCLUSIVE > > I think you could also do: default !PV_SHIM_EXCLUSIVE? Oh, yes, in this case I can indeed. I've mechanically used the form wanted when the prompt isn't unconditionally visible. Will switch. Jan
