On Fri, 2021-01-22 at 15:56 +0000, Ian Jackson wrote: > Previously, we let the Xen build system and startup scripts choose > which xenstored to use. Before we upgraded to Debian buster, that > gave us C xentored tests on ARM. Since then, armhf and arm64 have > both had enough ocaml support and we haven't been testing C xenstored > at all ! > > Change this, by selecting between C xenstored and Ocaml xenstored > "at random". Actually, this is based on the job name. So the same > job in different branches will use the same xenstored - which helps > avoid confusion. > > I have diffed the output of standalone-generate-dump-flight-runvars. > As expected, this addes a variable all_host_xenstored to every job. > > To make sure we have enough diversity, I eyeballed the results. In > particular: > * The smoke tests now have 2 C and 2 Ocaml, one of each on > ARM and x86. > * XTF tests have 2 oxenstored and 3 C xenstored. > * The ovmf flight has one of each > * The seabios and libvirt flights look reasonably mixed. > > Most other flights have enough jobs that I think things are diverse > enough without looking at them all in detail. > > I think this lack of testing needs fixing for the Xen 4.15 release. > So after review I intend to push this to osstest pretest, and may > force push it even if shows regressions.
Sounds good. In the patch series that I've recently posted to xen-devel there is also a 'make check' target in tools/ocaml/xenstored. There is a bit of plumbing to do before that is ready to be run automatically (there is a Dockerfile in the patchseries, so it should be possible to either adapt that, or vendor the 3rdparty dependencies for the purposes of osstest, whichever is preferable). These unit tests require OCaml 4.06+, so it'd be good to ensure that at least one of the builders has that (the Ubuntu:focal from my patch series should). Best regards, --Edwin
