On 22/01/2021 17:37, Ian Jackson wrote: > Andrew Cooper writes ("Re: [OSSTEST PATCH 7/7] make-flight: Stripy > xenstored"): >> Or does OSSTest have an explicit "is xenstored running" check after >> boot, before any further testing occurs? > No. > > If this turns out to ever happen we can improve the pre-checking. In > general I let the chips fall where they may, for test failures, and > improve the checking/logging later. Otherwise adding new tests > becomes very time-consuming (and there is also the risk that added > checks do not align with actual behvaiour).
I'm not objecting to this going in as-is, but I want to at least ensure we're not heading in blind. In practice, a lot of what I'm trying to achieve with some of the extended commentary on the autotests thread is better pre-checking of this kind of form, although admittedly at a rather lower level than "is xenstored running". > > Now that it's builing, I think it's fairly unlikely that we will > accidentally stop building one of the xenstoreds. Well - I ask specifically because there is a thread on xen-devel about upping the minimum supported version of Ocaml, in order to simplify a couple of aspects. This would manifest as oxenstored no longer building on older distros. (I've got no idea if the specific suggestion would impact OSSTest this time.) For now - lets just fix our testing gap. ~Andrew