Re: [PATCH 3/3] tools/libs: Fix headers.chk logic

[Jürgen Groß]

On 05.03.21 13:49, Andrew Cooper wrote:

c/s 4664034cd dropped the $(LIBHEADERSGLOB) dependency for the headers.chk
rule, without replacing it.

As headers.chk uses $^, a typical build looks like:

   andrewcoop@andrewcoop:/local/xen.git$ make -C tools/libs/devicemodel/
   make: Entering directory '/local/xen.git/tools/libs/devicemodel'
   for i in ; do \
       gcc -x c -ansi -Wall -Werror
       -I/local/xen.git/tools/libs/devicemodel/../../../tools/include \
             -S -o /dev/null $i || exit 1; \
       echo $i; \
   done >headers.chk.new
   mv headers.chk.new headers.chk

i.e. with an empty for loop, and checking only the $(AUTOINCS).

Reinsert a $(LIBHEADERS) dependency.

Fixes: 4664034cd ("tools/libs: move official headers to common directory")
Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>

Reviewed-by: Juergen Gross <jgr...@suse.com>


Juergen

OpenPGP_0xB0DE9DD628BF132F.asc
Description: application/pgp-keys

OpenPGP_signature
Description: OpenPGP digital signature