> I really like the early cleanup hook in your patches to cleanly unmap > any outstanding granted pages before zapping the range on vm area > destruction. It's something that I've been wanting to do for a while > -- very stability-adding. ;)
Yep; as far as we could tell, this should clean up the mappings reliably whatever happens - both clean munmaping and process destruction. It's nice that it only turns out as a small change: it would only be a small diff for us to maintain as a dom0 kernel patch, but maybe it's small enough to go upstream one day. I guess in this respect it would be nice if there were any other potential users of it (maybe non-Xen related)... Once the patch does what Xen folks want (or even before?), maybe it would be a good idea to post it on the Linux-mm list and see if people like the approach and if there's anything that could be done to make it more generic. This might smooth the road if it ever gets submitted upstream at a later date. Cheers, Mark -- Dave: Just a question. What use is a unicyle with no seat? And no pedals! Mark: To answer a question with a question: What use is a skateboard? Dave: Skateboards have wheels. Mark: My wheel has a wheel! _______________________________________________ Xen-ppc-devel mailing list Xen-ppc-devel@lists.xensource.com http://lists.xensource.com/xen-ppc-devel
