On 05/09/06, Jan Kiszka <[EMAIL PROTECTED]> wrote:
Currently XN_ISR_SHARED and XN_ISR_EDGE are unconditionally available for any configuration. So nothing stops a user from calling rtdm_irq_request( ... , RTDM_IRQTYPE_SHARED | RTDM_IRQTYPE_EDGE) even when IRQ shared infrastructure is off.
(the second call gives -EBUSY and a "bug" report is sent. I mean, if the user has overlooked "shared irq" section on the configure step and consider it a default behavior).
Probably the clean solution would be to export XN_ISR_SHARED and XN_ISR_EDGE only when their corresponding CONFIG_* parameters are defined.
Then e.g. rtdm skin should do :
#ifdef XN_ISR_SHARED
#define RTDM_IRQTYPE_SHARED XN_ISR_SHARED
#endif
and let a compiler complain on undefined symbol when a user tries to use SHARED/EDGE without proper CONFIG options. Although, I'm not sure it would be clear for all users.
Another approach,
in xnintr.h
#ifdef CONFIG_XENO_OPT_SHIRQ_LAYER
#define XN_ISR_SHARED 1
#else
#define XN_ISR_SHARED XN_ISR_WARNING
#endif
and then catch all wrong use cases in one place :
int xnintr_attach(xnintr_t *intr, void *cookie)
{
intr->hits = 0;
intr->cookie = cookie;
+ if (intr->flags & XN_ISR_WARNING) {
+ xnlogerr("blablabla...\n");
+ return -EINVAL;
+ }
#if defined(CONFIG_XENO_OPT_SHIRQ_LEVEL) || defined(CONFIG_XENO_OPT_SHIRQ_EDGE)
return xnintr_shirq_attach(intr, cookie);
#else /* !CONFIG_XENO_OPT_SHIRQ_LEVEL && !CONFIG_XENO_OPT_SHIRQ_EDGE */
return xnarch_hook_irq(intr->irq, &xnintr_irq_handler, intr->iack,
intr);
#endif /* CONFIG_XENO_OPT_SHIRQ_LEVEL || CONFIG_XENO_OPT_SHIRQ_EDGE */
}
?
@Dmitry: What happens under CONFIG_XENO_OPT_SHIRQ_LEVEL &&
!CONFIG_XENO_OPT_SHIRQ_EDGE when someone comes along with
XN_ISR_SHARED|XN_ISR_EDGE? Looks like the level-triggered shared handler
gets installed. Should we catch this? At Kconfig or at nucleus level?
Currently XN_ISR_SHARED and XN_ISR_EDGE are unconditionally available for any configuration. So nothing stops a user from calling rtdm_irq_request( ... , RTDM_IRQTYPE_SHARED | RTDM_IRQTYPE_EDGE) even when IRQ shared infrastructure is off.
(the second call gives -EBUSY and a "bug" report is sent. I mean, if the user has overlooked "shared irq" section on the configure step and consider it a default behavior).
Probably the clean solution would be to export XN_ISR_SHARED and XN_ISR_EDGE only when their corresponding CONFIG_* parameters are defined.
Then e.g. rtdm skin should do :
#ifdef XN_ISR_SHARED
#define RTDM_IRQTYPE_SHARED XN_ISR_SHARED
#endif
and let a compiler complain on undefined symbol when a user tries to use SHARED/EDGE without proper CONFIG options. Although, I'm not sure it would be clear for all users.
Another approach,
in xnintr.h
#ifdef CONFIG_XENO_OPT_SHIRQ_LAYER
#define XN_ISR_SHARED 1
#else
#define XN_ISR_SHARED XN_ISR_WARNING
#endif
and then catch all wrong use cases in one place :
int xnintr_attach(xnintr_t *intr, void *cookie)
{
intr->hits = 0;
intr->cookie = cookie;
+ if (intr->flags & XN_ISR_WARNING) {
+ xnlogerr("blablabla...\n");
+ return -EINVAL;
+ }
#if defined(CONFIG_XENO_OPT_SHIRQ_LEVEL) || defined(CONFIG_XENO_OPT_SHIRQ_EDGE)
return xnintr_shirq_attach(intr, cookie);
#else /* !CONFIG_XENO_OPT_SHIRQ_LEVEL && !CONFIG_XENO_OPT_SHIRQ_EDGE */
return xnarch_hook_irq(intr->irq, &xnintr_irq_handler, intr->iack,
intr);
#endif /* CONFIG_XENO_OPT_SHIRQ_LEVEL || CONFIG_XENO_OPT_SHIRQ_EDGE */
}
?
--
Best regards,
Dmitry Adamushko
_______________________________________________ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
