Gilles Chanteperdrix wrote: > Hi, > > I found some code which was referencing directly some > CONFIG_XENO_OPT_DEBUG_ variables with things like: > > #ifdef CONFIG_XENO_OPT_DEBUG_FOO > > This usage is incompatible with the pre-requisites of the assert.h > header that CONFIG_XENO_OPT_DEBUG_FOO should be defined at all times. > While grepping for CONFIG_XENO_OPT_DEBUG_, I found that we also have > many duplicates of construction like: > #ifndef CONFIG_XENO_OPT_DEBUG_FOO > #define CONFIG_XENO_OPT_DEBUG_FOO 0 > #endif /* CONFIG_XENO_OPT_DEBUG_FOO */ > > So, a patch follows which: > - replace the #ifdef with some #if XENO_DEBUG(FOO)
Should probably come as a separate patch. > - move all the initializations to assert.h > > This will make any reference to CONFIG_XENO_OPT_DEBUG_FOO outside of > assert.h suspicious, and easy to detect. How many duplicates did you find? Generally, I'm more a fan of decentralized management here (e.g. this avoids needless patch conflicts in central files). Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux _______________________________________________ Xenomai-core mailing list Xenomai-core@gna.org https://mail.gna.org/listinfo/xenomai-core
