-- I vote for attributing all patches in at least some format, so my vote
is:
-1
to [EMAIL PROTECTED]'s suggestion that we don't attribute patches.

As: <[EMAIL PROTECTED]> wrote - (original call for vote) ----
> Anyway.. anyone want to share their feelings on this subject? Do we need
to
> put in attributions for provided patches, no matter how big or how small
> (Wasn't that a Dr. Seus story?)

Although we don't seem to have this policy currently posted at
xml.apache.org, we should.  Either on one of the other apache websites or
in a list-email recently there was a specific proposal as to how to list a
patch contributor in a checkin log: might be nice to have a common format.
I think this is an important policy for an open source project, and makes
it 'feel' much more open to all contributors, whether they're regulars in
the apache world or someone new with good ideas.

Personally, I like to see a name or email address directly in the CVS log
for the specific file, but we could just reference a bugtracking number
there that points to the person's name or the like just as well.

-- Also: I agree with <[EMAIL PROTECTED]> that if a person requests it, we
should not publicise their email address in the change logs.  However I
think I disagree with the part about anonymity: If a committer likes a code
change given to them by an anonymous-requesting party, go ahead and check
it in with an attribution to 'anonymous'.  As long as the committer thinks
it's a good code change, and the original author doesn't want credit, who
else cares where it came from?  Obviously if a committer doesn't approve of
a change, then don't check it in.

Oh, and no, it's not worth the trouble to go back into a *previously*
committed file and scrub out any email addresses or the like - you gotta
ask ahead of time.

As: <[EMAIL PROTECTED]> wrote (comment on anonymous comtributions) ----
> Unless the patch submitter specifically asks not to:
>   the person's name and email address will be provided
>   in the commit message.
>
> Request to omit the email address may be entertained if
> mentioned at the time the patch was submitted. Once committed,
> its tedious to make edits on all the affected files.
>
> Request to omit name's will not be entertained, i.e. no anonymous
> submissions.

Sure, it would be nice to have project-wide 'contributors' files listing
everyone as well - perhaps in two sections, major contributors/committers
and others, but that takes extra work to maintain.  Anyone want to
volunteer - either for Xerces or Xalan?  8-)

----    ----
- Shane         Automation, Test, & Build guy
mailto:[EMAIL PROTECTED]    AIM:xsltest
  http://alphaworks.ibm.com/tech/LotusXSL
  http://xml.apache.org/xalan

Reply via email to