Petr Kuzel wrote:
> - XMLAttributes.getName(int,QName)
I added set/getName(int,QName) for convenience. I have no
problem with removing them if we then add the appropriate
set methods for the various parts of the qualified name.
> - XMLAttributes.addAttribute(QName, String, String)
> - XMLAttributes.setValue(String)
I updated the javadoc (and implementation) to be more
explicit about the behavior of implementing classes.
> - XMLDocumentFragmentHandler.emptyElement(QName, XMLAttributes)
Added.
> - should not XMLDocumentHandler be derived from XMLDocumentFragmentHandler?
> of both be derived from a new XMLContentHandler interface?
I'm not quite sure on this one. Yes, they share many of
the same methods. However, it doesn't make much sense for
a document handler to implement methods like start/
endDocumentFragment. And it seemed like a waste to add
another base interface just to separate the common methods.
> - I still miss definition of call order i.e. requirement for
> proper nesting of startXXX() and endXXX() events so it would
> be guaranteed that handler can use single stack for holding context
Which call order are you referring to?
> - startEntity(String,...) name can start with
> '%' denoting parameter entity
> '#' denoting character entity ref
The XNI javadoc details how an XNI-compliant component is
required to behave. However, there is no requirement that
an XNI parser be able to mark the start and end of character
references. The Xerces2 reference implementation can report
this by setting a feature but it's not on by default.
> - could be introduced XNIEntityIOException that
> should be propagated if a component gets IOException
> while scanning some external entity, so it would in
> fact convert fatal error (IOException is handled even
> more strict than fatal error) to error. Open issue
> what to do with pipeline components, they probably
> cannot rollback to state prior entity entering.
Hmmm... I need to think about this more.
Thanks for the comments. If you find any more deficiencies
in the javadoc (or accompanying docs in the "XNI Manual"),
feel free to attach patches to your post.
--
Andy Clark * IBM, TRL - Japan * [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
